whikloj / BagItTools

A PHP BagIt library
MIT License
11 stars 5 forks source link

End support for PHP 7.2 #28

Closed whikloj closed 3 years ago

whikloj commented 3 years ago

Due to changes to phpunit and phpcpd, running PHP 7.2 causes trouble.

It also has an EOL date of Oct 1, 2020 which in less than 3 months.

This removes testing of PHP 7.2 but other than changes to the testing framework the actual code should still be compatible.

This will be mark the start of the 3.0 version

codecov[bot] commented 3 years ago

Codecov Report

Merging #28 (e766f51) into main (150c777) will increase coverage by 1.04%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main      #28      +/-   ##
============================================
+ Coverage     81.16%   82.21%   +1.04%     
  Complexity      483      483              
============================================
  Files             7        7              
  Lines          1285     1282       -3     
============================================
+ Hits           1043     1054      +11     
+ Misses          242      228      -14     
Impacted Files Coverage Δ
src/Bag.php 78.95% <0.00%> (-0.09%) :arrow_down:
src/Fetch.php 88.54% <0.00%> (+6.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 150c777...e766f51. Read the comment docs.

collectiveaccess commented 3 years ago

PHP 7.2 was eol'ed last November, so it's all good :-)

whikloj commented 3 years ago

🤦 the days are sooooo long. Thanks @collectiveaccess you are correct.