Ensure special characters in manifest filepaths are urlencoded

whikloj / BagItTools

A PHP BagIt library

MIT License

11 stars 5 forks source link

Ensure special characters in manifest filepaths are urlencoded #35

Closed whikloj closed 2 years ago

whikloj commented 2 years ago

Resolves #33

This change:

Checks the payload manifests and fetch files of loaded Bags for any url encoded characters other than %0D, %0A and %25 and fails validation if it finds one. It also fails if it finds an unencoded newline or carriage return (though this really should never happen)
Correctly urlencodes these characters in payload manifests and fetch files written out by this library

whikloj commented 2 years ago

@pwinckles not sure if you had a specific test that you had been running that you'd like to retry with this PR. I added some tests but always appreciate more eyes.