search

whikloj / BagItTools

A PHP BagIt library
MIT License
11 stars 5 forks source link

Minor cleanup #51

Closed whikloj closed 2 years ago

whikloj commented 2 years ago

Switches to using / as file path separator internally for all OS'es. Fixes to get Windows to pass tests.

codecov[bot] commented 2 years ago

Codecov Report

Merging #51 (b7be6d8) into main (f2496ce) will increase coverage by 0.03%. The diff coverage is 89.47%.

@@             Coverage Diff              @@
##               main      #51      +/-   ##
============================================
+ Coverage     88.61%   88.65%   +0.03%     
+ Complexity      491      485       -6     
============================================
  Files             7        7              
  Lines          1274     1260      -14     
============================================
- Hits           1129     1117      -12     
+ Misses          145      143       -2
Impacted Files Coverage Δ
src/Bag.php 86.03% <81.25%> (+0.15%) :arrow_up:
src/BagUtils.php 92.39% <92.30%> (-0.47%) :arrow_down:
src/Commands/ValidateCommand.php 91.17% <100.00%> (ø)
src/Fetch.php 95.02% <100.00%> (-0.05%) :arrow_down:

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

whikloj commented 2 years ago

Thanks for the help @jonasraoni (🥇 ), once https://github.com/donatj/mock-webserver/pull/42 is merged then I can try re-enabling the Fetch tests too.

jonasraoni commented 2 years ago

Ok, I tested locally and it worked fine for me 👌