while-loop / runelite-plugins

BSD 2-Clause "Simplified" License
11 stars 22 forks source link

Zulrah Helper Venom Clouds - When do they appear? #26

Closed osrsgitacc closed 3 years ago

osrsgitacc commented 3 years ago

I love the zulrah helper plugin! I suck at pvm and I'm able to kill zulrah 75% of the time without much practice because of this plugin. The fact that they are a sequence of images that simply require user input makes it so beginners have to acknowledge what phase they are on which helps them learn, and makes it easier for programming too since there is no checking the zulrah phases directly (is that even possible?).

My biggest issue is knowing when to run to the next position for the upcoming zulrah phase. The more I fight zulrah, the more I get a grasp for how long each phase is, so I typically run just before zulrah ends its phase or as zulrah ends depending on how far I have to run. This works really well most of the time, especially when zulrah spits out its venom clouds at the beginning of a phase, but sometimes it shoots venom clouds at the end of the phase which forces me to take damage as I run through them to the next position.

I guess what I'm looking for is some indicator for the phase of when venom clouds will appear - whether at the beginning/end of a phase or even at all. There seems to be a lot of empty space at the top of the images for this information. I would also suggest making that information easy to register/decipher to the user at a quick glance as they are busy fighting zulrah and it wouldn't be good if they spent too much time looking at the plugin. It could also be togglable in the settings of whether or not the user might want to see this information? That's just my first brute force thought; maybe there's a better way.

while-loop commented 3 years ago

Hey there!

Unfortunately, having the plug-in in game state from within Zulrah is against RuneScapes rules. In order to actually have a Zulrah plugin, I can't show any indicators of where to stand or when things will change in-game.

It's in the same category as to why there aren't Jad plugins to tell you what to pray against as you're fighting him

You can read more on where jagex draws the line for banned plugins here https://oldschool.runescape.wiki/w/Update:Another_Message_About_Unofficial_Clients

Thanks!!

osrsgitacc commented 3 years ago

Oh sorry, I didn't mean to imply using game state to help, or doing anything that notifies the user when venom clouds appear, or anything in-game like that. That question about the game state thing was just a curiosity, but wasn't part of my actual question. I should have just been concise.

My question was to simply add a symbol to the images on the plugin pane that signifies whether venom clouds exist in the phase or not. After looking at where jagex draws the line for plugins, I guess it would be too much to ask for the symbol to indicate whether it exists at the beginning or ending of a phase on the plugin pane images, but I don't see an issue with venom clouds exist in a phase or not. Just having that information should be enough for me to learn zulrah better.

If it's still not allowed or don't even want to implement it, I understand. I just didn't want to let the suggestion be turned down on a misunderstanding by either of us. Really love the plugin! :)

while-loop commented 3 years ago

Ahh! I see.

To be honest, I haven't played runescape in a few months now.. But if someone is willing to edit the pictures in https://github.com/while-loop/runelite-plugins/tree/zulrah-helper/src/main/resources/phases I'd be more than glad to update the plugin!!

Let me know if this is something you or someone would like to do :)

osrsgitacc commented 3 years ago

I'll work on it right now :)

I'll post here again when I'm finished

osrsgitacc commented 3 years ago

Ok, I have finished. The images that I added venom clouds are separate images from the original for more flexibility. These images simply have "-venom" added to the end of their file names. This allows venom clouds to be togglable in the settings if you ever want to add that feature. I'm not sure what is needed for this, but I used the venom cloud image from https://www.osrsguide.com/osrs-zulrah-guide/ and scaled it down. After some research, I have added venom clouds to (including the dark versions):

I'm not sure how you want me to send these images to you, but hopefully it works well. Feel free to change any of this, as it is your plugin obviously.

while-loop commented 3 years ago

That's awesome! And even better for making it toggl- able.

A link to the imagines are fine!

osrsgitacc commented 3 years ago

magma_a-8-dark-venom magma_a-8-dark-venom magma_a-8-venom magma_a-8-venom magma_a-9-dark-venom magma_a-9-dark-venom magma_a-9-venom magma_a-9-venom magma_b-1-dark-venom magma_b-1-dark-venom magma_b-1-venom magma_b-1-venom magma_b-4-dark-venom magma_b-4-dark-venom magma_b-4-venom magma_b-4-venom magma_b-5-dark-venom magma_b-5-dark-venom magma_b-5-venom magma_b-5-venom magma_b-8-dark-venom magma_b-8-dark-venom magma_b-8-venom magma_b-8-venom magma_b-9-dark-venom magma_b-9-dark-venom magma_b-9-venom magma_b-9-venom normal-1-dark-venom normal-1-dark-venom normal-1-venom normal-1-venom normal-3-dark-venom normal-3-dark-venom normal-3-venom normal-3-venom normal-7-dark-venom normal-7-dark-venom normal-7-venom normal-7-venom normal-9-dark-venom normal-9-dark-venom normal-9-venom normal-9-venom start-1-dark-venom start-1-dark-venom start-1-venom start-1-venom tanz-1-dark-venom tanz-1-dark-venom tanz-1-venom tanz-1-venom tanz-3-dark-venom tanz-3-dark-venom tanz-3-venom tanz-3-venom tanz-5-dark-venom tanz-5-dark-venom tanz-5-venom tanz-5-venom tanz-7-dark-venom tanz-7-dark-venom tanz-7-venom tanz-7-venom tanz-10-dark-venom tanz-10-dark-venom tanz-10-venom tanz-10-venom venom-clouds-zulrah-100x97 venom-clouds-zulrah-100x97 magma_a-1-dark-venom magma_a-1-dark-venom magma_a-1-venom magma_a-1-venom magma_a-4-dark-venom magma_a-4-dark-venom magma_a-4-venom magma_a-4-venom magma_a-7-dark-venom magma_a-7-dark-venom magma_a-7-venom magma_a-7-venom