test-whitspace successfully but with manual check

Cinux90 commented 5 years ago

Type of Report

bug

Actual behaviour

Run test-whitspace.sh, with is finished successfully but ask to check some lines manually. E.g.

[cinux@cinux while_true_do.repo_epel]$ /bin/bash tests/test-whitespace.sh 

**************************************** 
***       Whitespace Checking        *** 
**************************************** 

**************************************** 
***  Whitespace checking successful  *** 
**************************************** 

Please also check the below Markdown files manually: 
./README.md:52:- hosts: servers 
./README.md:64:We are really happy, when somebody is joining the hard work. Please have a look

Expected behaviour

The test should be run in an error or a warning in case of manual checks. But never into successfully. Also possible is an Output as following:

[cinux@cinux while_true_do.repo_epel]$ /bin/bash tests/test-whitespace.sh 

**************************************** 
***       Whitespace Checking        *** 
**************************************** 

**************************************** 
***  Whitespace checking complete  *** 
**************************************** 
Results:
Please also check the below Markdown files manually: 
./README.md:52:- hosts: servers 
./README.md:64:We are really happy, when somebody is joining the hard work. Please have a look

dschier-wtd commented 5 years ago

The script currently tries to check md files seperately and does not fetch the return from it properly. @donvipre was this some design descision?

At least logically it seems fine, because the normal checks passed, but markdown output is forced to be manually checked.

donvipre commented 5 years ago

As markdown sometimes has "\<br>" as trailing two spaces I decided to not fail the test.. Suggestions are welcome ;)

dschier-wtd commented 5 years ago

Yep, I thought that some design was behind it ^^

In this case, changing the output to something that indicates a warning, with exit=0 would be nice. maybe with a yellow output.

donvipre commented 5 years ago

ok, I'll implement something like that

dschier-wtd commented 5 years ago

working in https://github.com/while-true-do/ansible-galaxy-skeleton/tree/rework-v1

while-true-do / ansible-skeleton