search

whimsicalraps / bowering

bowery, for norns
12 stars 3 forks source link

protect against nil values + util.wrap bug #7

Closed dndrks closed 3 years ago

dndrks commented 3 years ago

currently, util.wrap has a bug where if the max is less than the min then norns will just freeze. in bowering, this happens when P.get_count() is called while selected_script == 0.

until this is fixed upstream, i threw in some protective measures -- these also protect against error messages printing to maiden when encoder 3 is turned while selected_script == 0

trentgill commented 3 years ago

amazing thank you - i hadn't considered what happens when you press keys / turn encs while no script is selected.