search

whipper-team / whipper

Python CD-DA ripper preferring accuracy over speed
GNU General Public License v3.0
1.14k stars 89 forks source link

add ability to configure external executable options #244

Open RecursiveForest opened 6 years ago

RecursiveForest commented 6 years ago

whipper currently lacks the ability to adjust common options for underlying commands such as cd-paranoia read speed or flac encoding level. A way to specify arbitrary flags to the encoder, ripper, etc, should be provided in the configuration file, like EAC.

I think this is a natural time to add the ability to specify the exact path of commands like cd-paranoia or flac without the user having to edit their $PATH with each command, and to set the defaults to full paths such as /usr/bin/cd-paranoia.

JoeLametta commented 5 years ago

From the closed Pull Request #225:

I hadn't thought of it, but per-drive options are totally in the scope of #244. Should be very easy to implement.

xmixahlx commented 5 years ago

unsure why replaygain isn't in the scope of whipper (?) redirected here.

then... allowing processing of the output directory would be welcome to fix chmod permissions (600) and add replaygain (metaflac --preserve-modtime --add-replay-gain *.flac). needing to do so manually with each rip is somewhat annoying. i can't be the only one doing this...

JoeLametta commented 5 years ago

unsure why replaygain isn't in the scope of whipper (?) redirected here.

Well, whipper is just a ripper (not a tagging tool, etc.).

allowing processing of the output directory would be welcome to fix chmod permissions (600)

Could you provide more details about the quoted issue? It seems there's no trace of it in whipper's issue tracker...

Cheers, JoeLametta

tlc commented 5 years ago

They're probably referring to #284.