search

whipper-team / whipper

Python CD-DA ripper preferring accuracy over speed
GNU General Public License v3.0
1.14k stars 89 forks source link

redacted/waffles ready #288

Open MerlijnWajer opened 6 years ago

MerlijnWajer commented 6 years ago

I am trying to make a list of tickets we should finish before we can work with redacted/waffles on the logger part and then have whipper approved by both sites.

Anything else? We might have to rework the logger interface so that it can also call (external) binaries.

I didn't make a Milestone for this because (AFAIK) tickets can be only part of one milestone.

MerlijnWajer commented 6 years ago

@JoeLametta - any comments? I'm trying to get the ball rolling again on this.

peaveyman commented 6 years ago

We need to find out for sure which logger is going to be acceptable for redacted. And if redacted is good with it waffles will be.

MerlijnWajer commented 6 years ago

It seems like the current logger is fine - so we don't need #117. It's unclear if we will need #135. #221 would be nice to have, but for testing purposes we don't need it. #294 is important, though. #174 seems not that important for red right now since it mostly affects CDs with extra data, but we should get that fixed soon as well.

peaveyman commented 5 years ago

I can't see how 135 and 221 would be needed.

JoeLametta commented 5 years ago

  1. 117 I don't consider it a blocker: I'll surely update the README to clarify logger plugins current status. I may also update the morituri-eaclogger (or discontinue it).

  2. 221 I would say it's 99% done: again, not a blocker.

  3. 174 Would be nice having this fixed

  4. 135 Would be nice having this fixed: not a blocker.

  5. 294 I think this is needed.

Clear tutorials (more up to the websites perhaps)

Maybe #73?

itismadness commented 5 years ago

So in looking to implement this within a logchecker for Orpheus, one of the biggest hurdles I think we face is just knowing what are the possible logs that whipper may output that a user may check against. This includes a perfect log, but also what a log of a rip that has totally failed (or failed as much as whipper would allow while still producing a log). I can get an idea of it looking through the logger.py module that produces the YAML, but just concrete examples would be wonderfully helpful.

(Thanks for making the default log produced using YAML and not just straight text which has made parsing these things way easier than EAC/XLD).

MerlijnWajer commented 5 years ago

Alright. Going to try to get this rolling ASAP now. Remaining three tickets are all assigned to me it seems. ;)

nafanz commented 5 years ago

It is wonderful that it was approved at Orpheus. I hope that it will also be available for RED and Waffles.

peaveyman commented 5 years ago

I can't speak for RED but as for Waffles, when it gets back online you can expect Whipper to be an approved ripper.

JoeLametta commented 5 years ago

Even if it's an upstream bug I think #234 needs to be fixed too because it affects a big number of users.

7596ff commented 4 years ago

Is this still a priority?

JoeLametta commented 4 years ago

Is this still a priority?

Hi, those are just some of the issues scheduled for milestone 1.0. Unfortunately I don't have enough time / experience to handle everything on my own (that's why progress is slow) but I try to review every issue / pull request in a timely manner. Of course every contribution is encouraged and appreciated.

lighterowl commented 3 years ago

I can't speak for RED but as for Waffles, when it gets back online you can expect Whipper to be an approved ripper.

It never did. 😢

in-plaintext commented 4 months ago

What is the current state of the program on RED?