search

whipper-team / whipper

Python CD-DA ripper preferring accuracy over speed
GNU General Public License v3.0
1.14k stars 89 forks source link

Edit tags before rip the CD without needing to use Musicbrainz database. #342

Open henriqueelder opened 5 years ago

henriqueelder commented 5 years ago

Hello, would be nice if we could Edit the CD and tracks informations manually without needing the Musicbrainz database because sometimes we found wrong filenames and CD titles on Musicbrainz.

srussel commented 5 years ago

I would also like this feature. The use cases that I have for it are:

  1. I have a few music CD-Rs that don't belong in MusicBrainz but I would like to add the metadata before ripping.

  2. For some of my CDs the metadata is in MusicBrainz and is correct but I would like to tailor the metadata for my needs. For example shortening lengthy titles or adding a series name to the title so all albums in a series are together when sorted.

  3. I make a minor correction in MusicBrainz but have to wait 7 days for the change to be applied. I would like to make the same change to track list whipper uses so I can immediately rip the Cd instead of waiting a week.

I know it is possible to use other programs to edit metadata afterwards but then the cue sheet titles won't match. If whipper opened the metadata in a text editor for editing it would also be possible to store this text file in the output directory so if I ever need to rerip the CD I could reuse the text file with my modifications.

Nord-Licht commented 4 years ago

Just created an account here.

This feature would really be cool to have. The use cases are obviously, I can absolutely confirm srussels thoughts on this.

srussel commented 3 years ago

This patch is a hack I have been using for a few months to work around this issue. It adds an "--edit" option that writes the metadata to a text file, opens it in an editor for the user to update, then parses it back into whipper before continuing with the rip.

whipper-edit-metadata.txt

Californian commented 3 years ago

This patch is a hack I have been using for a few months to work around this issue. It adds an "--edit" option that writes the metadata to a text file, opens it in an editor for the user to update, then parses it back into whipper before continuing with the rip.

whipper-edit-metadata.txt

@srussel I can't seem to apply that to the latest version -- would you mind submitting a PR or putting it up on a fork?

srussel commented 3 years ago

@Californian https://github.com/srussel/whipper/commits/edit-metadata

JuniorJPDJ commented 3 years ago

Very cool hack tbh, it would be cool to have it done like this in official whipper.

Californian commented 3 years ago

@Californian https://github.com/srussel/whipper/commits/edit-metadata

Yusss thank you!

oech3 commented 2 years ago

@srussel I tested https://github.com/srussel/whipper/commits/edit-metadata with CD which occurs #453 . I can edit metadata with env EDITOR=pluma whipper cd -d /dev/sr1 rip --edit.But edited title was not used and fails to rip.

srussel commented 2 years ago

@oech3 I have rebased my patch https://github.com/srussel/whipper/tree/edit-metadata It works for me. If it still does not work, try putting some print statements in readMetadata(). That is where the text file is parsed and updates the whipper metadata.

srussel commented 2 years ago

@oech3 I found I was only updating the title, not the disambiguated title, which depending on whether you were using %d or %D for the disc title may not have worked. I have updated my patch to support editing both.

oech3 commented 2 years ago

@srussel Thankyou.I can rip now. I failed to rip due to output_directory/soundtrack/'Various Artists - VERYLONGTITLE' was not editable.

privacy313 commented 1 year ago

thanks for the work @srussel ! this helped me out a bunch today. hopefully this gets merged w main branch soon enough.