whipper-team / whipper

Python CD-DA ripper preferring accuracy over speed
GNU General Public License v3.0
1.14k stars 89 forks source link

Store and reuse TOC #538

Open Forage opened 3 years ago

Forage commented 3 years ago

It can take some time for whipper cd info to finish reading the TOC. When starting whipper cd rip the same process is repeated. Providing a way to store the TOC when using info and reusing the same when following up with a rip would speed up the process a bit.

While it being just a rough idea, several things come to mind:

In addition to a speed-up for when you happen to use info before rip, it would also function as groundwork for a possible Whipper GUI in the future. You'd want to systematically view the disc content before ripping.

Forage commented 3 years ago

I see now (#335) that you're actually doing the opposite at the moment by removing the caching, the only difference being that the TOC was stored during the rip process instead of info.

Does this make the use-case described above a no go?

JoeLametta commented 3 years ago

@Freso, @MerlijnWajer what's your opinion about this?

Forage commented 3 years ago

An alternative would be to have a 'light' version of info not doing an extensive analysis but sticking to basic disc and track info like number, length, ISRC, title, MB additions, etc.

MerlijnWajer commented 2 years ago

Sorry for the late response, but yeah, I'd argue in favour of removing the cache rather than caching more. Yes, it's annoying that it sometimes reads the entire CD again to get an accurate toc, but a (wrong) cache can be much more annoying, at least in my experience.