search

whipper-team / whipper

Python CD-DA ripper preferring accuracy over speed
GNU General Public License v3.0
1.15k stars 91 forks source link

whipper completely stops when one track is faulty #560

Open vguttmann opened 2 years ago

vguttmann commented 2 years ago

I have a CD that seems to have a bad track or something, and when trying to rip it, whipper finds that track 9 is faulty, tries to rip it multiple times, and then gives up completely.

Here is the output:

[vincent@diskettenrechner ~]$ WHIPPER_DEBUG=DEBUG WHIPPER_LOGFILE=whipper.log whipper cd rip
CDDB disc id: fe10a113
MusicBrainz disc id HEgroOLMxzYBNp7U2hbiSCgyl44-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+19+319494+150+9093+27348+45817+63357+81755+94623+111539+129011+146995+166278+182802+201477+212729+233368+248555+262751+277010+290404&tracks=19&id=HEgroOLMxzYBNp7U2hbiSCgyl44-
Disc duration: 01:10:57.920, 19 audio tracks

Matching releases:

Artist  : The Royal Philharmonic Orchestra, Matthew Freeman
Title   : Symphonic Queen: The Greatest Hits
Duration: 01:10:02.866
URL     : https://musicbrainz.org/release/82609ad0-8286-4c22-91dd-e435289a22d5
Release : 82609ad0-8286-4c22-91dd-e435289a22d5
Type    : Compilation
Barcode : 0028947962687
Country : Germany
Cat no  : 479 6268

Artist  : The Royal Philharmonic Orchestra
Title   : Symphonic Queen: The Greatest Hits
Duration: 01:10:02.866
URL     : https://musicbrainz.org/release/eace2379-7b55-44e6-b258-240d6e796562
Release : eace2379-7b55-44e6-b258-240d6e796562
Type    : Compilation
Barcode : 0028947962687
Country : Australia
Cat no  : 479 6268

Track 1 finished, found 7 Q sub-channels with CRC errors
Track 2 finished, found 7 Q sub-channels with CRC errors
Track 3 finished, found 8 Q sub-channels with CRC errors
Track 4 finished, found 7 Q sub-channels with CRC errors
Track 5 finished, found 8 Q sub-channels with CRC errors
Track 6 finished, found 9 Q sub-channels with CRC errors
Track 7 finished, found 8 Q sub-channels with CRC errors
Track 8 finished, found 17 Q sub-channels with CRC errors
Track 9 finished, found 178 Q sub-channels with CRC errors
Track 10 finished, found 25 Q sub-channels with CRC errors
Track 11 finished, found 23 Q sub-channels with CRC errors
Track 12 finished, found 61 Q sub-channels with CRC errors
Track 13 finished, found 15 Q sub-channels with CRC errors
Track 14 finished, found 37 Q sub-channels with CRC errors
Track 15 finished, found 38 Q sub-channels with CRC errors
Track 16 finished, found 40 Q sub-channels with CRC errors
Track 17 finished, found 43 Q sub-channels with CRC errors
Track 18 finished, found 126 Q sub-channels with CRC errors
Track 19 finished, found 119 Q sub-channels with CRC errors
I am doing something.   0 %
flac 1.3.4
Copyright (C) 2000-2009  Josh Coalson, 2011-2016  Xiph.Org Foundation
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

01. The Royal Philharmonic Orchestra, Matthew Freeman - We Will Rock You.flac:  
done         
Peak level: 0.870667                      
Rip quality: 100.00%
I am doing something.   0 %               
flac 1.3.4
Copyright (C) 2000-2009  Josh Coalson, 2011-2016  Xiph.Org Foundation
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

02. The Royal Philharmonic Orchestra, Matthew Freeman - I Want It All.flac:     
done         
Peak level: 0.995483                      
Rip quality: 100.00%
I am doing something.   0 %               
flac 1.3.4
Copyright (C) 2000-2009  Josh Coalson, 2011-2016  Xiph.Org Foundation
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

03. The Royal Philharmonic Orchestra, Matthew Freeman - These Are the Days of Our Lives.flac: done         
Peak level: 0.891205                      
Rip quality: 100.00%
I am doing something.   0 %               
flac 1.3.4
Copyright (C) 2000-2009  Josh Coalson, 2011-2016  Xiph.Org Foundation
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

04. The Royal Philharmonic Orchestra, Matthew Freeman - Tie Your Mother Down.flac: done         
Peak level: 0.807373                      
Rip quality: 100.00%
I am doing something.   0 %               
flac 1.3.4
Copyright (C) 2000-2009  Josh Coalson, 2011-2016  Xiph.Org Foundation
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

05. The Royal Philharmonic Orchestra, Matthew Freeman - Love of My Life.flac:   
done         
Peak level: 0.999939                      
Rip quality: 100.00%
I am doing something.   0 %               
flac 1.3.4
Copyright (C) 2000-2009  Josh Coalson, 2011-2016  Xiph.Org Foundation
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

06. The Royal Philharmonic Orchestra, Matthew Freeman - Crazy Little Thing Called Love.flac: done         
Peak level: 0.999847                      
Rip quality: 100.00%
I am doing something.   0 %               
flac 1.3.4
Copyright (C) 2000-2009  Josh Coalson, 2011-2016  Xiph.Org Foundation
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

07. The Royal Philharmonic Orchestra, Matthew Freeman - Don’t Stop Me Now.flac: done         
Peak level: 0.999969                      
Rip quality: 100.00%
I am doing something.   0 %               
flac 1.3.4
Copyright (C) 2000-2009  Josh Coalson, 2011-2016  Xiph.Org Foundation
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

08. The Royal Philharmonic Orchestra, Matthew Freeman - One Vision.flac: done         
Peak level: 0.751221                      
Rip quality: 100.00%
("track can't be ripped. Rip attempts number is equal to %d", 5)

I know that it would be a good idea to let the user know that something is amiss, but stopping the rip entirely when encountering a faulty track while ripping the first 8 tracks seems like bad behavior to me. I'd prefer if faulty tracks were just skipped, since whipper rips and outputs every track up until the faulty one. whipper.log.gz

also, it seems like the string formatting in the error message isn't quite right 🙃

I'm using it on Manjaro (from Manjaro repos), version 0.10.0

github-actions[bot] commented 2 years ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

vguttmann commented 2 years ago

I did try to rip it using cdparanoia directly, and only get a few pluses on track 9.

As per cdparanoia FAQ (https://xiph.org/paranoia/faq.html#corr), those are most definitely harmless and should have no audible defects.

eharris commented 2 years ago

You can also try using the --keep-going flag. That won't solve the bad track, but it will allow it to rip the later tracks.