whipper-team / whipper

Python CD-DA ripper preferring accuracy over speed
GNU General Public License v3.0
1.15k stars 91 forks source link

Detection of completed rip directory should occur immediately after release selection #573

Open eharris opened 2 years ago

eharris commented 2 years ago

When running whipper cd rip, if there already exists a completed rip directory that aborts the rip with output directory <directory> is a finished rip, that only occurs after whipper continues on to do the cdrdao scan, which can sometimes be quite lengthy.

Instead, the completed rip detection check should be done before it uses cdrdao to do the full index table scan, as it already has detected the release info so has all the info it needs to do that check.