Save FLAC file after embedding cover art

whipper-team / whipper

Python CD-DA ripper preferring accuracy over speed

GNU General Public License v3.0

1.11k stars 88 forks source link

Save FLAC file after embedding cover art #610

Closed JoshWVS closed 3 months ago

JoshWVS commented 3 months ago

Without this call to .save(), I don't think the FLAC file with cover art is ever persisted. (See TaggingTask._tag, which already calls w.save().) I wish I had noticed this before ripping a couple hundred CDs :sweat_smile:

Thanks very much for your work on whipper, it's been instrumental in digitizing my CD collection!

MerlijnWajer commented 3 months ago

Great find, thank you very much for this pull request!

MerlijnWajer commented 3 months ago

@JoeLametta - I'm going to merge this PR as it looks sensible to me and you seem to be busy.