Closing disc tray should only happen when supported

whipper-team / whipper

Python CD-DA ripper preferring accuracy over speed

GNU General Public License v3.0

1.11k stars 88 forks source link

Closing disc tray should only happen when supported #615

Open hadess opened 2 months ago

hadess commented 2 months ago

Using whipper-0.10.0-11.fc39.x86_64

WARNING:whipper.program.utils:command 'eject -t /dev/sr0' returned with exit code '1' (b'eject: CD-ROM tray close command failed: No such file or directory')

My CD drive is a Hitachi-LG BU40N blu-ray drive that doesn't have a tray that can be programmatically closed.

Ideally, whipper could detect that the device doesn't support closing the tray, and would set drive_auto_close for the drive itself rather than globally.

github-actions[bot] commented 2 months ago

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing instructions.

MerlijnWajer commented 2 months ago

I suppose we might be able to use the CDC_OPEN_TRAY flag, presuming that is set correctly for the CDROM_GET_CAPABILITY ioctl. Maybe you could check if that's set correctly for your drive?