search

whipper-team / whipper

Python CD-DA ripper preferring accuracy over speed
GNU General Public License v3.0
1.16k stars 91 forks source link

Make it easier to select from multiple releases #617

Open hadess opened 7 months ago

hadess commented 7 months ago

Selecting a release requires copy/pasting all or part of the release UUID, which isn't the clearest of interactions. Ideally, the matching releases would be numbered, and typing one of the numbers would select it.

INFO:whipper.command.cd:using configured read offset 6
INFO:whipper.command.cd:checking device /dev/sr0
WARNING:whipper.program.utils:command 'eject -t /dev/sr0' returned with exit code '1' (b'eject: CD-ROM tray close command failed: No such file or directory')
CDDB disc id: c20af40e
MusicBrainz disc id ahg7JUcfR3vCYBphSDIogOOWrr0-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+14+210523+150+2075+13098+29890+47353+63285+78105+92940+112278+124523+133725+143635+149430+162508&tracks=14&id=ahg7JUcfR3vCYBphSDIogOOWrr0-
Disc duration: 00:46:44.973, 14 audio tracks

Matching releases:

Artist  : The Offspring
Title   : Smash (made by Disctronics)
Duration: 00:46:44.182
URL     : https://musicbrainz.org/release/91587782-e6e5-4f09-a614-47320c149006
Release : 91587782-e6e5-4f09-a614-47320c149006
Type    : Album
Barcode : 045778643226
Country : United States
Cat no  : 86432-2

Artist  : Offspring
Title   : Smash
Duration: 00:46:44.182
URL     : https://musicbrainz.org/release/021b8436-4c5f-3aa0-ac08-3ebf6470ada3
Release : 021b8436-4c5f-3aa0-ac08-3ebf6470ada3
Type    : Album
Country : United Kingdom

Artist  : Offspring
Title   : Smash
Duration: 00:46:44.182
URL     : https://musicbrainz.org/release/b50d155a-5cde-3600-b768-5a6fc0ce57eb
Release : b50d155a-5cde-3600-b768-5a6fc0ce57eb
Type    : Album
Barcode : 8714092643220
Country : Europe
Cat no  : 6432-2

Artist  : Offspring
Title   : Smash
Duration: 00:46:44.182
URL     : https://musicbrainz.org/release/3600cdf3-f591-3a8f-97e4-b582e7beb3f7
Release : 3600cdf3-f591-3a8f-97e4-b582e7beb3f7
Type    : Album
Barcode : 6001211560332
Country : South Africa
Cat no  : CDEPIT 1

Artist  : Offspring
Title   : Smash (1995 reissue)
Duration: 00:46:44.182
URL     : https://musicbrainz.org/release/acc90e28-3b6b-4e82-bef5-1f262599284a
Release : acc90e28-3b6b-4e82-bef5-1f262599284a
Type    : Album
Barcode : 045778643226
Country : United States
Cat no  : 86432-2

Please select a release [91587782-e6e5-4f09-a614-47320c149006]: b50d155a-5cde-3600-b768-5a6fc0ce57eb
INFO:whipper.common.program:picked requested release id b50d155a-5cde-3600-b768-5a6fc0ce57eb
Artist: Offspring
Title : Smash
[...]

This is also discussed in https://github.com/whipper-team/whipper/pull/549 which only makes it clearer what the current behaviour is, rather than changing it.

hadess commented 7 months ago

See also https://github.com/whipper-team/whipper/issues/205

MerlijnWajer commented 7 months ago

(I agree this makes sense, and it doesn't seem like it would be too hard to implement)

hadess commented 6 months ago

Another point to take into account, this happened because of a stray space before the release ID:

INFO:whipper.command.cd:using configured read offset 6
INFO:whipper.command.cd:checking device /dev/sr0
CDDB disc id: f90e3d12
MusicBrainz disc id dVukfZ08RlVQuqYfOL60SeweAV8-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+18+273555+150+19657+30175+49812+65022+66767+84210+101910+108992+128717+144430+154930+158950+180470+203202+224162+231362+256785&tracks=18&id=dVukfZ08RlVQuqYfOL60SeweAV8-
Disc duration: 01:00:45.400, 18 audio tracks

Matching releases:

Artist  : The Avalanches
Title   : Since I Left You
Duration: 01:00:49.036
URL     : https://musicbrainz.org/release/ccf667b9-0705-4e87-8c96-13948316efa6
Release : ccf667b9-0705-4e87-8c96-13948316efa6
Type    : Album
Barcode : 724353493929
Country : Australia
Cat no  : MODCD014

Artist  : The Avalanches
Title   : Since I Left You
Duration: 01:00:49.036
URL     : https://musicbrainz.org/release/7064948b-af9f-3c45-b7a0-4109a61693ff
Release : 7064948b-af9f-3c45-b7a0-4109a61693ff
Type    : Album
Barcode : 634904013820
Country : United Kingdom
Cat no  : XLCD138

Artist  : The Avalanches
Title   : Since I Left You
Duration: 01:00:49.036
URL     : https://musicbrainz.org/release/0ae16051-e092-3919-ba51-976dfc027cc0
Release : 0ae16051-e092-3919-ba51-976dfc027cc0
Type    : Album
Barcode : 724381028421
Country : France
Cat no  : 7243 8 10284 2 1

Please select a release [ccf667b9-0705-4e87-8c96-13948316efa6]: 7064948b-af9f-3c45-b7a0-4109a61693ff
WARNING:whipper.common.program:requested release id ' 7064948b-af9f-3c45-b7a0-4109a61693ff', but none of the found releases match
INFO:whipper.command.cd:FreeDB identifies disc as ['The Avalanches / Since I Left You']
CRITICAL:whipper.command.cd:unable to retrieve disc metadata, --unknown argument not passed