search

whipper-team / whipper

Python CD-DA ripper preferring accuracy over speed
GNU General Public License v3.0
1.14k stars 89 forks source link

Rework the test framework #8

Open abendebury opened 8 years ago

JoeLametta commented 8 years ago

Two new test error out because of JoeLametta/whipper@ed4c9f4ece0bdbc428a8027c2c2f45bdf9a74444 I'm going to update them.

JoeLametta commented 8 years ago

Now there are only 6 errors left (even with morituri's master repository).

JoeLametta commented 8 years ago

Because of #2 all tests should be completely reviewed and updated. For the moment being I've just commented out the six failing tests (inherited from morituri) in order to still get meaningful Travis CI build results.

I'm keeping this one open.

RecursiveForest commented 7 years ago

In general our tests are misleadingly succesful. A lot of things go untested, and a lot of tests are red herrings. (c.f. some tests I removed in my cdrdao rewrite) Our entire test framework needs work, and unfortunately is limited by the fact that there is no good way to emulate a cd drive device in userspace afaik.