search

whiskerz007 / proxmox_hassos_install

MIT License
884 stars 191 forks source link

qcow storage is assumed to be a directory, for storage using other methods this will fail on creating the VM step #102

Open liambresnahan opened 3 years ago

liambresnahan commented 3 years ago

I ran into this issue as my VM storage is over nfs (connected to a NAS), when running the script I was repeatedly getting an error of [ERROR] 255@136 Unknown failure occured. - on tracking through the code I see this:

if [ "$STORAGE_TYPE" = "dir" ]; then DISK_EXT=".qcow2" DISK_REF="$VMID/" IMPORT_OPT="-format qcow2" fi

without this working correctly whatever storage type selected it will fail in the import and set step.

There are a few ways to solve (call our in README that nfs or other storage is not supported, check in code for dir only and fail with error if not the case, support nfs stores (probably more work)). I might be able to submit a PR for some of this, what would be the recommended approach?

INDIVISUM commented 3 years ago

This seems to be the same problem I had. It worked fine when installing to an iSCSI LVM on my end. I would prefer the option to install to NFS as that is what I use the most.