whiskerz007 / proxmox_hassos_install

MIT License
887 stars 192 forks source link

Update install.sh #95

Open kevindesl opened 3 years ago

whiskerz007 commented 3 years ago

I do not understand what this PR is accomplishing.

barbw1re commented 3 years ago

I think this may be trying to "fix" #106 (see my comment on the issue) which fails executing

qm set $VMID \
  -boot order=sata0 > /dev/null

but I don't think the solution is to remove it, more likely the better option would be to understand if there is a change in qm set arguments for different proxmox versions and/or if the previous -bootdisk sata0 method universally works and then call qm set as appropriate.