whiskeylover / idreamoftoast

idreamoftoast
Apache License 2.0
1 stars 0 forks source link

Merge separate html files into one #17

Closed danriti closed 11 years ago

danriti commented 11 years ago

@whiskeylover so I noticed that you initially developed the site, you split the front end functionality into two separate html files:

This design doesn't take full advantage of the "single page app" design because it requires you to load a second html file while using the site. While it's not a major disadvantage, to truly harness the power that is Backbone (and all other Javascript MVC frameworks), you really want to front load as much as physically possible on the first load.

Thus, I'm proposing the following change:

The proposed routes are:

I understand this is a major change, however this is the right time to do it, as it will allow us to be more flexible in the future and grow the sites features.

As always, I'd like to hear your thoughts and lets discuss before we make any changes!

whiskeylover commented 11 years ago

I agree. I was thinking about the same thing, actually.

We can also always show the textbox where the user enters the dream on the top of the page. That way the user does not have to go back to the index page.

danriti commented 11 years ago

@whiskeylover I agree that a "google-like" approach (always show the textbox, just move it around) should definitely be taken, however I would say we should wait to do that after this issue is resolved.

i will try to get started on this issue asap!

whiskeylover commented 11 years ago

Just checked your changes. Looks awesome.

danriti commented 11 years ago

@whiskeylover thanks! I have a few more changes I need to make this week and then it should be ready.

danriti commented 11 years ago

@whiskeylover so this is ready to go! i know some of my changes are quite a departure from the previous implementation, so i'd be happy to walk through some of the code with you via Google Hangout if you have any questions!

otherwise, let me know if your ok with me merging this into master. as always, any comments/feedback welcome!

whiskeylover commented 11 years ago

Lets merge this. We can talk about this after our other Google Hangout call.