whisperfish / libsignal-service-rs

A Rust version of the libsignal-service-java library for communicating with Signal servers.
https://whisperfish.github.io/libsignal-service-rs/libsignal_service
GNU Affero General Public License v3.0
69 stars 32 forks source link

Enable keep-alive for provisioning socket #269

Closed gferon closed 11 months ago

gferon commented 11 months ago

Just found this while starting to look into linking errors.

Reference: https://github.com/signalapp/Signal-Desktop/blob/c6c072319993fefd9fcfab55ca77dc75263bc875/ts/textsecure/SocketManager.ts#L273

codecov[bot] commented 11 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (34ad911) 3.65% compared to head (a1429c9) 3.65%.

Files Patch % Lines
libsignal-service-actix/src/push_service.rs 0.00% 2 Missing :warning:
libsignal-service-hyper/src/push_service.rs 0.00% 2 Missing :warning:
libsignal-service/src/websocket.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #269 +/- ## ===================================== Coverage 3.65% 3.65% ===================================== Files 38 38 Lines 2818 2818 ===================================== Hits 103 103 Misses 2715 2715 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rubdos commented 11 months ago

Are there no ws's anymore without KA? If so, don't forget to also amend actix :-)

gferon commented 11 months ago

True dat, and yes they're all with keep alive.