whisperfish / libsignal-service-rs

A Rust version of the libsignal-service-java library for communicating with Signal servers.
https://whisperfish.github.io/libsignal-service-rs/libsignal_service
GNU Affero General Public License v3.0
68 stars 31 forks source link

Dependency updates #280

Closed rubdos closed 9 months ago

rubdos commented 9 months ago

Now that we have 1.75... we can bump all the things!

I'm keeping away from bumping -protocol now.

rubdos commented 9 months ago

Cherry picked and fixed the protobuf dep from #270

codecov[bot] commented 9 months ago

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (926c555) 2.30% compared to head (bcae066) 3.39%. Report is 4 commits behind head on main.

Files Patch % Lines
libsignal-service/src/groups_v2/model.rs 0.00% 12 Missing :warning:
libsignal-service/src/utils.rs 0.00% 5 Missing :warning:
libsignal-service/src/groups_v2/operations.rs 0.00% 2 Missing :warning:
libsignal-service/src/groups_v2/manager.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #280 +/- ## ======================================== + Coverage 2.30% 3.39% +1.09% ======================================== Files 34 37 +3 Lines 2478 2855 +377 ======================================== + Hits 57 97 +40 - Misses 2421 2758 +337 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rubdos commented 9 months ago

Comparison is base (ce4ba97) 3.60% compared to head (f7a28d0) 17.25%.

Hmm. We didn't have libsignal-service in CI for testing and coverage, I added it here.

rubdos commented 9 months ago

Bumps MSRV to 1.75 because of RPITIT. I anticipate this quickly will get traction in several libs.

rubdos commented 9 months ago

I saw some funky behaviour, the websocket seemed to be resetting.

2024-01-10T17:45:32.869635Z ERROR whisperfish::worker::client: Error starting stream: Websocket error: HTTP status 504 Gateway Timeout
2024-01-10T17:45:32.869732Z  INFO whisperfish::worker::client: Retrying in 10
2024-01-10T17:46:06.972704Z TRACE websocket: libsignal_service_hyper::websocket: Will start websocket at Url { scheme: "wss", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("chat.signal.org")), port: None, path: "/v1/websocket/", query: None, fragment: None }
2024-01-10T17:46:07.102194Z  WARN libsignal_service_hyper::websocket: Websocket closing: Some(CloseFrame { code: Error, reason: "org.eclipse.jetty.websocket.core.exception.WebSocketException: WebSocketResourceProvider OPEN method error: WebSocketConnec" })
2024-01-10T17:46:07.922719Z ERROR set up message receiver:websocket: libsignal_service::websocket: SignalWebSocket: Websocket error: end of web request stream; socket closing
2024-01-10T17:46:07.923564Z  INFO libsignal_service::messagepipe: sink was closed: Ok(())
2024-01-10T17:46:07.923604Z DEBUG whisperfish::worker::client: Attempting reconnect