search

whisperfish / libsignal-service-rs

A Rust version of the libsignal-service-java library for communicating with Signal servers.
https://whisperfish.github.io/libsignal-service-rs/libsignal_service
GNU Affero General Public License v3.0
69 stars 32 forks source link

Fix base64 #289

Closed Schmiddiii closed 10 months ago

Schmiddiii commented 10 months ago

Fixes #288.

Note that BASE64_STANDARD_NO_PAD does not work as this requires base64 to not have padding, which is also not the case for Signal. This therefore needs a custom engine.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0ad842f) 17.12% compared to head (5b95d5f) 17.12%. Report is 1 commits behind head on main.

Files Patch % Lines
libsignal-service/src/utils.rs 0.00% 4 Missing :warning:
libsignal-service/src/groups_v2/manager.rs 0.00% 1 Missing :warning:
libsignal-service/src/groups_v2/operations.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #289 +/- ## ======================================= Coverage 17.12% 17.12% ======================================= Files 38 38 Lines 3078 3078 ======================================= Hits 527 527 Misses 2551 2551 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rubdos commented 10 months ago

Seems like you miss some imports in account_manager.rs.