search

whisperfish / libsignal-service-rs

A Rust version of the libsignal-service-java library for communicating with Signal servers.
https://whisperfish.github.io/libsignal-service-rs/libsignal_service
GNU Affero General Public License v3.0
68 stars 31 forks source link

MessageSender::send_contact_details seems to have some parameters too many #294

Open rubdos opened 7 months ago

rubdos commented 7 months ago

I'm working on #206, and I'm adding the include_pni_signature bool everywhere. I notice that send_contact_details has the online parameter and the recipient parameter, but the former should always be false, and the latter is always the self-recipient. So we'll want to clean that out.

Or am I missing something?