whisperfish / libsignal-service-rs

A Rust version of the libsignal-service-java library for communicating with Signal servers.
https://whisperfish.github.io/libsignal-service-rs/libsignal_service
GNU Affero General Public License v3.0
69 stars 32 forks source link

Log verbosity and sanitization #335

Closed rubdos closed 1 month ago

rubdos commented 1 month ago

Implementing Display for several datatypes, for use in traces.

rubdos commented 1 month ago

Would be cool to use valuable for some stuff, but I'm too lazy to research that decently atm.

gferon commented 1 month ago

tbh it's a relatively shitty trait to implement. fmt::Display is good enough in most cases.

rubdos commented 1 month ago

tbh it's a relatively shitty trait to implement. fmt::Display is good enough in most cases.

Yeh indeed... Very much overkill. Merge this thing?