whisperfish / presage

A high-level Rust library to help write clients for the Signal Messenger.
GNU Affero General Public License v3.0
107 stars 20 forks source link

Remove deleted account from group #110

Open Schmiddiii opened 1 year ago

Schmiddiii commented 1 year ago

From testing in the Whisperfish room, one gets a 404 when sending a message to a room with a group member that disappeared. As @rubdos mentioned, presage should maybe handle that 404 and delete that user from the group.

rubdos commented 1 year ago

@gferon if you manage to find out how Android/iOS handles a 404 here, please do let me know. I have the exact same situation in WF, and I am wondering how I should deal with it correctly.

N.b., this is not someone who disappeared from the group, rather, it's someone that deleted their Signal account altogether. Maybe they reregistered and got a new UUID, maybe something entirely different happened.

Schmiddiii commented 1 year ago

Another ugly thing I have noticed just now: As sending the message fails with the 404, messages will not be accepted into the store.

rubdos commented 1 year ago

https://github.com/whisperfish/libsignal-service-rs/pull/215

rubdos commented 1 year ago

Also https://gitlab.com/whisperfish/whisperfish/-/merge_requests/396