search

whisperfish / presage

A high-level Rust library to help write clients for the Signal Messenger.
GNU Affero General Public License v3.0
114 stars 21 forks source link

Disappear messages after timer ends #168

Open julianfairfax opened 1 year ago

julianfairfax commented 1 year ago

I know presage turns off disappearing messages when you send a message to a contact with them on. But, it would be nice if disappearing messages sent from other devices (and so leaving it on) would disappear when the timer ends. (Downstream issue: #69)

julianfairfax commented 1 year ago

Basically a duplicate of #93

julianfairfax commented 1 year ago

Now that #93 has been fixed by @Schmiddiii, this is an issue

julianfairfax commented 1 year ago

@gferon what would the difficulty be of implementing this now that #93 has been fixed?

gferon commented 1 year ago

Not particularly hard, we can add a function that runs every second (or less often) and deletes expired messages.

Schmiddiii commented 1 year ago

I guess a cleaner solution would be to have a store-method that gets the next timestamp where a message needs to be deleted and repeatedly sleep to that point and delete. This could also be maybe put into a "maintainence queue" which e.g. deletes messages, resends failed messages (once failed messages are stored), .... Probably not as simple as repeatedly trying every second.

baumkuchen42 commented 6 months ago

Hey, are there plans to work on this issue soon? I'm worried people might exploit this issue, to the detriment of their conversation partner.

gferon commented 6 months ago

Hey, are there plans to work on this issue soon? I'm worried people might exploit this issue, to the detriment of their conversation partner.

Fair point, I'll see if I can get back to it soon.