whisperfish / presage

A high-level Rust library to help write clients for the Signal Messenger.
GNU Affero General Public License v3.0
113 stars 21 forks source link

Fix for kyber errors #225

Closed Schmiddiii closed 9 months ago

Schmiddiii commented 9 months ago

Fixes https://github.com/whisperfish/libsignal-service-rs/issues/273. Note that for the fix to work, the device probably needs to be re-linked.

This was tested for about half an hour yesterday, and continued testing today. No message got lost due to the InvalidKyberPreKeyId-error (but I got some other errors which are weird, see the Signal chat; these do only seem to be from one other account and do only seem to be message delivery receipts).

The fix is to register pre-keys (including the kyber pre keys) with the server. This is also what Signal-Desktop does, see here.

Schmiddiii commented 9 months ago

This fix has now been tested by me and a few others on a beta of Flare for multiple days without any issues. So I will promote the "potential fix" to a "fix".

gferon commented 9 months ago

Thanks!