search

whisperfish / rust-phonenumber

Library for parsing, formatting and validating international phone numbers.
Apache License 2.0
162 stars 55 forks source link

Add mnc/mcc fields to Carrier #59

Open gferon opened 1 year ago

gferon commented 1 year ago

Will be used in https://github.com/whisperfish/libsignal-service-rs/pull/241 instead of having this in libsignal-service-rs.

rubdos commented 1 year ago

Should we be bumping versions in merge requests? Is it not more logical to bump them independently? I'm not very good with version management myself though.

codecov[bot] commented 10 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1f46da5) 71.81% compared to head (4b07e85) 72.16%. Report is 3 commits behind head on main.

Files Patch % Lines
src/carrier.rs 88.23% 2 Missing :warning:
src/formatter.rs 60.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ========================================== + Coverage 71.81% 72.16% +0.35% ========================================== Files 19 19 Lines 1955 1969 +14 ========================================== + Hits 1404 1421 +17 + Misses 551 548 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rubdos commented 3 months ago

@gferon any chance you could have a look at this some time soon? Otherwise I might take this up.