search

whisperfish / rust-phonenumber

Library for parsing, formatting and validating international phone numbers.
Apache License 2.0
156 stars 55 forks source link

Bump version to 0.3.4+8.13.34 #67

Closed rubdos closed 5 months ago

rubdos commented 9 months ago

Bump version and update underlying dataset to the latest release at https://github.com/google/libphonenumber/releases/tag/v8.13.34.

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.86%. Comparing base (1f46da5) to head (0cf3934). Report is 3 commits behind head on main.

:exclamation: Current head 0cf3934 differs from pull request most recent head 5e1a662. Consider uploading reports for the commit 5e1a662 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #67 +/- ## ========================================== + Coverage 71.81% 71.86% +0.05% ========================================== Files 19 19 Lines 1955 1955 ========================================== + Hits 1404 1405 +1 + Misses 551 550 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

virtualritz commented 5 months ago

Why is this still not merged? The DB shipped with this crate is now over a year old.

Is there anything we can do to help?

I could also make a PR for the DB from last week (8.13.34) + fixed warnings + bumped dependencies as I have a version with those changes.

But before I do that I'd like to know what the chances are, of that being accepted. :grin:

rubdos commented 5 months ago

Why is this still not merged?

I was mostly waiting on a second pair of eyes from @gferon, actually.

gferon commented 5 months ago

On it, I'll check right now! I think we wanted to first merge another PR and completely forgot about it.

rubdos commented 5 months ago

I could also make a PR for the DB from last week (8.13.34) + fixed warnings + bumped dependencies as I have a version with those changes.

But before I do that I'd like to know what the chances are, of that being accepted. 😁

If you have it around, feel free to push that instead! Maybe make a separate PR for the version bump though!

gferon commented 5 months ago

Why is this still not merged?

I suppose CI failed or something else happened, actually 🤔

Screenshot 2024-04-11 at 20 47 11

I updated the assets to v8.13.34 and will merge this and publish to crates.io afterwards!

gferon commented 5 months ago

Just released the new version on crates.io - https://crates.io/crates/phonenumber/0.3.4+8.13.34