whisthq / whist

Whist Browser
https://whist.com
Apache License 2.0
7 stars 3 forks source link

Reorganize Monorepo #1407

Closed philippemnoel closed 3 years ago

philippemnoel commented 3 years ago

Feature Name & Description

This is mostly a tracking issue here for the next documentation day, and to get other people's thoughts. I think we've been mostly "blindly" merging repos into this monorepo and it's worked well, but eventually we'll want to reorganize the project structure to something that is a bit more streamlined.

Notably, I'm thinking all the containers/ecs repos should be one, maybe with a structure like this: fractal --> containers -----> host ---------> service --------------> all of our host-service code ---------> aws --------------> all of our taskdef/AWS-specific code ---------> azure --------------> when we go multicloud, we can add cloud-specific code in the different sections, if relevant ---------> gcp -----> images ---------> all of our container images stuff

This is just a random thought, it may not be exactly how we want to structure it, but that's one example. Another example would be consolidating website/core-ts/client-apps within a single subfolder, maybe "frontend" or something like that, since they all relate together.

philippemnoel commented 3 years ago

I'd be curious to hear @djsavvy @sardination @npip99 @FishmanL @mingy98 @rpadaki's thoughts here, whenever you get a chance

sardination commented 3 years ago

I kind of like this, under the assumption that we're going to be adding more pieces (like in your diagram above for aws/azure/gcp). But if there's no plan to add extra parts, then I think it might add too many levels of indirection for little benefit. Could be clean though!

philippemnoel commented 3 years ago

closing, see discussion in linear