search

whisthq / whist

Whist Browser
https://whist.com
Apache License 2.0
7 stars 3 forks source link

Improve Emojis on Fractal browser #2242

Closed philippemnoel closed 3 years ago

philippemnoel commented 3 years ago

Bug Description @rpadaki is going to hate me for opening this, but here I go anyway.

I was on Notion on Fractal and realized the emoji look really jank compared to on my macOS browser, see below on Fractal:

Capture d’écran, le 2021-05-12 à 12 01 56

vs on Chrome on macOS:

Capture d’écran, le 2021-05-12 à 12 02 47

At some point we added tweemoji to Fractal in the base image, and I remember the emojis got a lot better. I don't know if this is an issue where tweemoji is just not nearly as great or if it broke, but regardless I think eventually we'll want better emoji than this, if we can afford it.

How to Reproduce A list of steps to reproduce the bug, if it is reproducible.

Context List your computer OS, specifications, browser version, etc.; anything that might be relevant to reproducing and diagnosing the bug.

rpadaki commented 3 years ago

For legal reasons we cannot install apple's native emojis in our containers. And anyways apple doesn't give us a way to use them. However, Twitter open sourced their emojis, which is what we use.

I'm not sure why you think the top ones look jank tbh, but obviously they are different because they are different emojis. Quite frankly, I think the ones on the top look better than the ones on the bottom haha, but in general we should make decisions to do whatever looks best.

@neilyio @djsavvy would love to get your thoughts on this

rpadaki commented 3 years ago

Just go to twitter and type some emojis and you'll notice that those are exactly the emojis we are using on notion and elsewhere, that's how to tell that this is working.

neilyio commented 3 years ago

They seem similar enough to me to not be bothered by it. It does seem like there's less colour in the Fractal Browser emojis, which is maybe less friendly. I think this is the kind of thing to prioritize based on how we find people are using the browser. If it's for work apps (excel, etc), it might not be worth optimizing emoji rendering. If they're using a lot of twitter or messaging, maybe emojis are more important.

philippemnoel commented 3 years ago

alright, in this case let's close this for now and assess in the future