search

whisthq / whist

Whist Browser
https://whist.com
Apache License 2.0
4 stars 3 forks source link

Display shaded Whist logo in the omnibar #7296

Closed owenniles closed 1 year ago

owenniles commented 2 years ago

Feature Name & Description

whisthq/brave-core#186 causes the flat Whist logo to show on the left side of the omnibar on brave://... pages. Ideally, the shaded logo would appear, but I don't think it's possible to represent the shaded logo in a .icon file due to the lack of expressivity of Chromium draw commands.

Screen Shot 2022-06-20 at 1 36 26 PM

The Problem It Fixes

Inconsistent branding

Feature Implementation

No clue! git grep -F kProductIcon or cs.chromium.org may be useful.

philippemnoel commented 2 years ago

The logo on the right appears to be shaded, so presumably it should be possible to have the shaded logo on the left as well, no? -- I'm assuming they both use the same draw commands to be displayed

owenniles commented 2 years ago

I talked to @mingy98 a bit about this yesterday. It turns out that the logo on the right-hand side of the omnibox is just a PNG. It may be possible that we can use a PNG on the left-hand side as well.

Screen Shot 2022-07-19 at 1 17 58 PM

philippemnoel commented 2 years ago

let's do the PNG then! should be fairly simple

philippemnoel commented 1 year ago

so apparently this can't be done, no big deal