search

whisthq / whist

Whist Browser
https://whist.com
Apache License 2.0
6 stars 3 forks source link

core: refactor capture devices #7492

Open hardening opened 1 year ago

hardening commented 1 year ago

This big refactor abstract capture devices to prepare things for the weston backend. The refactoring make it possible to have multiple capture device at the same time (capture device is not fixed at build time)

Ticket(s) Closed

Description

Implementation

Documentation & Tests Added

Testing Instructions

PR Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #7492 (858ab6e) into dev (c104c46) will decrease coverage by 0.70%. The diff coverage is 45.89%.

:exclamation: Current head 858ab6e differs from pull request most recent head 73138ff. Consider uploading reports for the commit 73138ff to get more accurate results

@@            Coverage Diff             @@
##              dev    #7492      +/-   ##
==========================================
- Coverage   56.13%   55.42%   -0.71%     
==========================================
  Files         158      166       +8     
  Lines       32519    33836    +1317     
==========================================
+ Hits        18255    18755     +500     
- Misses      14010    14827     +817     
  Partials      254      254
Flag Coverage Δ *Carryforward flag
backend-services 49.31% <ø> (ø) Carriedforward from c104c46
protocol 56.63% <45.89%> (-0.92%) :arrow_down:

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
protocol/server/video.c 0.00% <0.00%> (ø)
protocol/whist/video/capture/nvidiacapture.c 0.00% <0.00%> (ø)
protocol/whist/video/capture/nvx11capture.c 0.00% <0.00%> (ø)
protocol/whist/video/codec/encode.c 48.06% <0.00%> (-0.27%) :arrow_down:
protocol/whist/video/codec/nvidia_encode.c 0.00% <0.00%> (ø)
protocol/whist/video/cudacontext.c 43.75% <16.66%> (ø)
protocol/test/capture_test.cpp 53.14% <53.14%> (ø)
protocol/whist/video/transfercapture.c 56.41% <62.50%> (+56.41%) :arrow_up:
protocol/whist/video/capture/capture.c 62.82% <62.82%> (ø)
protocol/whist/video/capture/memorycapture.c 71.73% <71.73%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d16a63...73138ff. Read the comment docs.

github-actions[bot] commented 1 year ago

Protocol End-to-End Streaming Test Results

Experiments Summary

Expand Summary :white_check_mark: **Experiment 1** - Bandwidth: Unbounded, Delay: None, Packet Drops: None, Queue limit: default. Download logs: ```bash aws s3 cp s3://whist-e2e-protocol-test-logs/david/capture_dev_plus_test/2022_11_22@17-56-44/ 2022_11_22@17-56-44/ --recursive ``` :white_check_mark: **Experiment 2** - Bandwidth: variable between 15Mbit and 30Mbit, Delay: 10 ms, Packet Drops: None, Queue Limit: None, Conditions change over time? Yes, frequency is variable between 1000 ms and 2000 ms. Download logs: ```bash aws s3 cp s3://whist-e2e-protocol-test-logs/david/capture_dev_plus_test/2022_11_22@18-02-23/ 2022_11_22@18-02-23/ --recursive ``` :white_check_mark: **Experiment 3** - Bandwidth: variable between 10Mbit and 20Mbit, Delay: 10 ms, Packet Drops: None, Queue Limit: None, Conditions change over time? Yes, frequency is variable between 500 ms and 2000 ms. Download logs: ```bash aws s3 cp s3://whist-e2e-protocol-test-logs/david/capture_dev_plus_test/2022_11_22@18-06-30/ 2022_11_22@18-06-30/ --recursive ``` :x: **Experiment 4** - Bandwidth: 10Mbit, Delay: 10 ms, Packet Drops: None, Queue Limit: 100 packets, Conditions change over time? No.. Download logs: ```bash aws s3 cp s3://whist-e2e-protocol-test-logs/david/capture_dev_plus_test/2022_11_22@18-10-37/ 2022_11_22@18-10-37/ --recursive ```

Full Results: link here

hardening commented 1 year ago

@wangyu- a bunch of good remarks, will treat them

wangyu- commented 1 year ago

@hardening could you please not squeese all commits into one immediately after addressed the reviews? it makes reviewer very hard to know what you have changed since last review.

@hardening can you recover the commit history?

hardening commented 1 year ago

@wangyu- Yeah sorry I'm rebasing and commit amending to have a clean log, but this has the drawback that you loose changes. So I don't think I can get back the changes since last commit (although I'm not a git expert)