Murder Mystery Review

[franfranfranfran]

Rubric Score

Criteria 1: Valid Python Code

• Score Level: 4
• Comment(s): Program runs smoothly, without any errors!

Criteria 2: Implementation of Project Requirements

• Score Level: 4
• Comment(s): Great job including all required classes and methods! The code is clear and easy to read. Nice job including some well-placed and descriptive comments throughout. These little bits of information go a long way to make your code easier to read and understand.

Criteria 3: Software Architecture

• Score Level: 2
• Comment(s): In general, the classes and methods interact neatly and clearly. There are just a few examples of places where relationships and the code can be made more concise. -find_text_similarity should take two text sample objects as input. That way, you do not have to recreate and recalculate every bit of information about the text - a text sample already has all the info. -Inside of the text sample class, you calculate and store the prepared text so why not use that when you need it instead of calculating it again for word_count_frequency and n_gram_frequency?

Criteria 4: Uses Python Language Features

• Score Level: 3
• Comment(s): Nice use of various built-in Python language features like replace(), split(), zip() and others. Inside of the frequency_comparison function, you can get rid of the keys() method. for items in table1: will work how you expect it to. Also, consider saving the two values, from table1 and table2, that you compare and use here instead of repeatedly accessing them.

Criteria 5: Produces Accurate Output

• Score Level: 4
• Comment(s): Overall, great job testing your functions along the way to ensure the end result is accurate. One little thing to consider adjusting is the conversion to int in the average sentence length function. Losing some decimal precision could make a difference in the end, so I think it'd be best to keep that bit of info as precise as possible.

Overall Score: 17/20

Great work on this project. With a couple small tweaks, everything will be looking perfect. As you continue working on this project, and others, try to always keep an eye out for ways to make your code more concise and to beef up / clear up the relationships between your various classes and methods. Avoid repeating yourself wherever possible. Have fun and keep up the good work!

[whistleholic]

Thanks for the feedback! Will work to correct the issues mentioned above. Unfortunately, I am not sure I'll be able to work on it before the deadline on Monday. Am I required to resubmit to finish the code-academy intensive? Or could I just take these comments into future projects to improve my software architecture and language features?

[franfranfranfran]

sure thing! no need to re-submit, these are just things to keep in mind for the future.

• francis

On Sat, Jun 8, 2019 at 8:53 PM whistleholic notifications@github.com wrote:

Thanks for the feedback! Will work to correct the issues mentioned above. Unfortunately, I am not sure I'll be able to work on it before the deadline on Monday. Am I required to resubmit to finish the code-academy intensive? Or could I just take these comments into future projects to improve my software architecture and language features?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/whistleholic/pwp-capstones/issues/1?email_source=notifications&email_token=AEDVX6352VQFKOH7JX3QIHDPZRIAXA5CNFSM4HWHYYZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIBJ4I#issuecomment-500176113, or mute the thread https://github.com/notifications/unsubscribe-auth/AEDVX6Z74UCSC5WGY3AHNW3PZRIAXANCNFSM4HWHYYZA .