white-nl / commerce-mollie-plus

Mollie Klarna integration for Craft Commerce
Other
3 stars 5 forks source link

#1 use orderReferenceFormat if possible #3

Closed rbrv closed 2 years ago

WHITE-developer commented 2 years ago

Sorry we can't accept this pull request as it would break some Craft setups.

As we mentioned in the issue #1:

Some shops use dates or separate sequencers for their order references. So even if we try to generate the reference at the moment we push the data to Mollie, it won’t be saved in Craft and we would end up with references that don’t match the Craft version.

The generated reference in this case can be different each time it's generated, even for the same order.

And even if we do try to save the generated reference when we push the data to Mollie, it would still disrupt normal Craft order flow.

rbrv commented 2 years ago

Understood!