search

white-rabbit-apps / communikitty-ios

The CommuniKitty app for iOS with Swift 3
0 stars 1 forks source link

Change filter options in CLImageEditor to have usable filters similar to Instagram #5

Open michaelbina opened 8 years ago

michaelbina commented 8 years ago

From @michaelbina on May 18, 2016 4:31

The current options for filters are not useable and don't make the picture prettier than it was. Look into the CLImageEditor code for where filters are made and create new ones that may more closely match Instagram filters.

Copied from original issue: white-rabbit-apps/white-rabbit-ios#230

michaelbina commented 8 years ago

If you're not sure about what parameters to change to get the filters to look good, just get it to a point where we can add and remove the current filters as needed and then tweak the settings until we get good stuff

michaelbina commented 8 years ago

From @AlinaChernenko on August 10, 2016 11:31

@michaelbina could you give me more details of what to change? see attached files of Instagram filters. This is current filters http://prntscr.com/c3x9n8 . Shall I add filters like brightness, contrast etc? img_5469 img_5470

michaelbina commented 8 years ago

Don't worry about the things like brightness and contrast. Those are all things built in to CLImageEditor that we can turn on later if we want. My problem is that the actual filters on the filter part of the editor don't really make the picture look very good. I want to start playing around with the settings on the filters so that we can make ones that look more like the ones from Instagram like Clarendon, Gingham, etc up in the screenshot. If you can make a new one or start editing the settings for one then we can start adjusting settings to get good ones.

michaelbina commented 8 years ago

From @AlinaChernenko on August 29, 2016 6:29

@michaelbina sorry, still not clear for me. http://prntscr.com/cbka45 do you mean changing the image/text on the filters panel or the image that is filtered/processed already like http://prntscr.com/cbkbp5 ? If it's the processed image, please give me an example/specifics of how you think this image should look like within the existing filters scope or in relation to instagram filters (there are different filters names).

michaelbina commented 8 years ago

I mean changing the actual filters to be more like Instagram yes. It would be fine to just copy a couple of Instagram filters as best as you can and then we can go from there.

michaelbina commented 8 years ago

From @AlinaChernenko on August 29, 2016 13:52

@michaelbina ClImageEditor library is on c-obj language, I am not good with this language, but I'll try to update it.

michaelbina commented 8 years ago

From @AlinaChernenko on August 29, 2016 14:25

@michaelbina do you have instagram filters formula? I found this example https://github.com/danielgindi/Instagram-Filters but it's old list of filters.