white07S / Fibonacci-Retracement

Machine learning model for finding Retracement,Support and Resistance
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

Data split #11

Closed bujowskis closed 1 year ago

bujowskis commented 1 year ago

Notes:

Start-end dates:

bujowskis commented 1 year ago

forgot to mention

bujowskis commented 1 year ago

I've added the "naive" puller, but it needs rework - note the fixme in datasplit.py

bujowskis commented 1 year ago

added the remaining two fixme

white07S commented 1 year ago

After understanding the module of the B/S model it doesn't make sense to train a model based on a time frame rather than we should train a model based on categorized stocks.

bujowskis commented 1 year ago

is the trader holiday problem solved then? I've seen you @white07S add some trader calendar there

white07S commented 1 year ago

Yeah, it's solved and you can close this issue that trader calendar is specifically for stock data to provide accurate data in matplotlib tick module to make it understandable.

Regarding training and testing, we will be splitting stock based on categorization.

bujowskis commented 1 year ago

can you elaborate how this split will work?

bujowskis commented 1 year ago

From our talk, the split is as follows:

bujowskis commented 1 year ago

moved the remaining things that are irrelevant to this issue per se to their own issues, this one seems to be done