white07S / Fibonacci-Retracement

Machine learning model for finding Retracement,Support and Resistance
BSD 3-Clause "New" or "Revised" License
7 stars 1 forks source link

OOP polymorphism (for 3 different Sup-Res-Fib calculations code) #19

Closed bujowskis closed 1 year ago

bujowskis commented 1 year ago

basically some common sort of interface all three methods will share to simplify the usage

bujowskis commented 1 year ago

this is preliminary to the rework of Calculation codes, need the fundamental components to figure out the right OOP patterns (among which, polymorphism)

lukik45 commented 1 year ago

@bujowskis I added a branch that targets this issue.

bujowskis commented 1 year ago

I'm moving it to in review, seems some good stuff done there, it may have already done the trick

bujowskis commented 1 year ago

I need to review it, but unfortunately no sooner than next weekend

bujowskis commented 1 year ago

decided it's fine as-it-is, moved on to other tasks