Add financial data - Githubissues

white07S / Fibonacci-Retracement

Machine learning model for finding Retracement,Support and Resistance

BSD 3-Clause "New" or "Revised" License

7 stars 1 forks source link

Add financial data #6

Closed bujowskis closed 1 year ago

bujowskis commented 1 year ago

[x] clean the data
[x] add

white07S commented 1 year ago

Rather than adding the actual data and increasing the size of the repo, I decided that we download based on your need and that's why I have added the script.

bujowskis commented 1 year ago

What about cleaning? Sharing the same working data copy sounds better cleaning-wise

white07S commented 1 year ago

tbh there is no need to clean the data because our source is already providing cleaned data

bujowskis commented 1 year ago

I'm marking clean the data checkbox then, omw to review

bujowskis commented 1 year ago

@white07S I think requirements.txt doesn't cover the requirements for downloading the external data. Is that by design?

bujowskis commented 1 year ago

okay, so from a phone talk

requirements.txt is not supposed to cover the downloading data scripts (if it turns out otherwise, we add the requirements)
after some refactoring and adding the __main__ I was able to download the data, no issues (see `exemplary-external.csv)
I've added some todo's, but they're not of that big priority at this point and we may add them later

The build is passing (since no inference in the tests), LGTM