whitead / dmol-book

Deep learning for molecules and materials book
https://dmol.pub
Other
594 stars 115 forks source link

NLP feedback #104

Closed kjappelbaum closed 2 years ago

kjappelbaum commented 2 years ago

This seems like an awesome reference http://nlp.seas.harvard.edu/2018/04/03/attention.html

whitead commented 2 years ago

idempotent (?), permutation invariance is about atom ordering in molecular graph (not string), and question about bijective. Can't be injective, since strings like [nop][nop][C] will not be covered.

whitead commented 2 years ago

Addressed this feedback and my comment above to myself in #134