Support Liquibase 4 - Githubissues

whiteclarkegroup / liquibase-linter

Quality control for your Liquibase scripts

https://whiteclarkegroup.github.io/liquibase-linter/

Apache License 2.0

26 stars 7 forks source link

Support Liquibase 4 #118

Open bbrouwer opened 4 years ago

bbrouwer commented 4 years ago

Liquibase 4 came out earlier this year. With a few modifications, liquibase-linter works with Liquibase 4. The biggest difference is that the ResourceAccessor is incompatible with the one from Liquibase 3. It is fairly straightforward to get it working. You can see what it took in my branch.

This means that there is no way to get a single version of liquibase-linter to work with both Liquibase 3 and 4.

It might be possible to make a liquibase-linter-3 that includes liquibase-linter (which supports 4.0) as a dependency. It would need to include the old LintAwareChangeLogParser in the old location and it would need a different ConfigLoader in order to work. It might only need to override the ConfigLoader.loadConfig method.

And as a bonus, upgrading to Liquibase 4 fixes #92

What are your thoughts on this?

bbrouwer commented 4 years ago

Would we want to split this up into multiple artifacts? Something like this:

liquibase-linter-aggregate
- liquibase-linter - for version 4.0.0
- liquibase-linter3 - for version 3.x, also uses liquibase-linter as a dependency
- liquibase-linter-tests - so we can run full tests for 3.x and 4.x. Or do we want to build a Maven type:test-jar out of liquibase-linter that liquibase-linter3 can reference and avoid making liquibase-linter-tests?

ilyanoskov commented 3 years ago

What is the timeline for adding the support for liquibase 4?

stolp commented 3 years ago

I came here looking for liquibase 4 support as well. Patiently waiting for news.

arvydzutis commented 3 years ago

any news?

JezzFielden commented 3 years ago

Hi guys, had a few emails about this at WCG. Just wanted to let you know it will get looked at but no timeline as yet.

ivanjensen-ep commented 1 year ago

My team made similar changes as the OP to get the linter working with liquibase 4, and frankly, it's fantastic, and just what we were looking for. We'd love to be able to just pull an "official" version, instead of another fork.

I know this issue is pretty old and stale, but there is definitely still interest! 👍

joabetc commented 1 month ago

Any plans/news in regards supporting Liquibase 4?

murdos commented 4 weeks ago

I recently discovered this project, and I would like to use it, but unfortunately it's not maintained anymore. Is there some folks here interested by joining effort to maintain a community fork?

joabetc commented 2 weeks ago

I recently discovered this project, and I would like to use it, but unfortunately it's not maintained anymore. Is there some folks here interested by joining effort to maintain a community fork?

@murdos that's a good idea. I'm interested.

murdos commented 2 weeks ago

@joabetc : you can find my fork here: https://github.com/liquibase-linter/liquibase-linter/

I've integrated previous work of @bbrouwer related to improving reporters and Liquibase 4 support. A dedicated maven plugin is now also available if you don't want to use liquibase-maven-plugin. Snapshot versions are already published to OSSRH, and I'll soon make a first official release after testing it on existing projects :)

murdos commented 2 weeks ago

FYI a first release is available https://github.com/liquibase-linter/liquibase-linter/releases/tag/0.6.0 with liquibase 4 support and more features.