Add option to add Facebook Pixel

patimio66 commented 4 months ago

In this PR I added an option to add Facebook (or Meta) pixel immediately, like the Google Analytics, just by providing an ID.

PS. Please be kind, that's my first commit to an open source project yet. But don't hesitate to tell me what I've done wrong!

patimio66 commented 1 month ago

I actually see that is solves #25

toonvandenbos commented 1 month ago

Hi @patimio66! Thanks for your PR.

I took a closer look to it and made some changes. As you asked for feedback, do not hesitate to take a look at my 2 last commits:

First I reverted some code style changes that did not match our styling rules in order to keep the repository homogeneous and easy to maintain ;
Then I changed the way the Facebook cookie is registered. You added it inside a group, which is only useful when multiple cookies are set by the same script. Since there's only one (apparently), I simplified its configuration.

I never implemented Facebook's Pixel myself, so I must admit I don't know much about it. Does it indeed only set one first-party cookie? If so, great work!

Also, thanks for providing all the translations. Are you sure the cookie description is correct? Because if it really does what you described, it seems a little intrusive from my point of view and I don't understand why anybody would accept such a cookie 😅

I'm waiting for your feedback in order to get this merged. Thanks again!

whitecube / laravel-cookie-consent

Add option to add Facebook Pixel #45