search

whitecube / nova-flexible-content

Flexible Content & Repeater Fields for Laravel Nova
MIT License
788 stars 231 forks source link

Fix existing layouts breaking as of 1.0.9 #474

Closed mabdullahsari closed 1 year ago

mabdullahsari commented 1 year ago

469 broke existing layouts. This PR rectifies that.

jsmit99 commented 1 year ago

@voidgraphics @toonvandenbos good fix, existing layouts broke.

jsmit99 commented 1 year ago

@toonvandenbos needs a tagged version / release I think.

toonvandenbos commented 1 year ago

We're looking into a few related fixes and PRs in order to group everything in a single release.

jsmit99 commented 1 year ago

Hmm alright, do you have any idea when will things be released?

mabdullahsari commented 1 year ago

@jsmit99 You can use a composer patch in the meantime, until a version is tagged.

jsmit99 commented 1 year ago

Hmm but it shouldnt take to much time to create a minor release? It's not working for latest nova now.

mabdullahsari commented 1 year ago

@jsmit99 Use dev-master then until it's tagged? There are plenty of options to make it work "now".

PieterCappelle commented 1 year ago

Please revert this. https://github.com/whitecube/nova-flexible-content/pull/469

mabdullahsari commented 1 year ago

Please revert this. #469

Why revert this fix that fixes the defect?

PieterCappelle commented 1 year ago

@mabdullahsari See this issue, I'm experiencing exactly the same since this update > https://github.com/whitecube/nova-flexible-content/issues/475.