Regression: Delete button is broken

Senexis commented 3 months ago

After the Laravel 11 compatibility pull request (#509) the delete button for deleting a block (using confirmRemove) has regressed to being broken again.

Currently it is not possible to delete the block due to the delete "button" no longer being an actual button.

Relevant composer show -i output:

laravel/framework                            v11.0.8
laravel/nova                                 4.33.0
whitecube/nova-flexible-content              v1.1.0

justindantzer commented 3 months ago

@Senexis I could be mistaken, but I believe this issue is related to a reported issue over on the Nova issue repository, and not related to the recent Laravel compatability PR.

Apparently, some components have been removed, and it is likely the <danger-button/> component used on the DeleteGroupModal.vue needs to be replaced with another component that is available.

If someone is able to throw together a PR, this may be what's required. It looks like within Nova (looking at the DeleteResourceModal.vue in the source) there is a button component used similarly to this:

import { Button } from 'laravel-nova-ui';

<Button
    type="submit"
    :loading="working"
    state="danger"
    label="Delete"
/>

Jaspur commented 3 months ago

@voidgraphics can you solve this?

voidgraphics commented 3 months ago

Yes actually, I have this scheduled for later today!

voidgraphics commented 3 months ago

Should work now in v1.1.1

whitecube / nova-flexible-content

Regression: Delete button is broken #513