search

whitecube / nova-page

Static pages content management for Laravel Nova
https://whitecube.github.io/nova-page
MIT License
238 stars 41 forks source link

Adding empty $model propety to the main resource #18

Closed shalawani closed 5 years ago

shalawani commented 5 years ago

According to integrate laravel-auditing we should have $model property defined on the resource

toonvandenbos commented 5 years ago

Hi @shalawani,

Why set the model to an empty string? Is there an issue if $model is declared and defaults to null?

Thanks!

shalawani commented 5 years ago

Hi @Nyratas Yes there is an issue when integrating laravel-auditing with your package

toonvandenbos commented 5 years ago

@shalawani that's what I understood from your first message. To be more precise, my question would be:

Is there still a problem with the integration of laravel-auditing if you set $model to null, as shown in this example:

public static $model;

Instead of declaring it as an empty string as you did:

public static $model = '';

?

shalawani commented 5 years ago

I think the issue was from another thing.

I tested it now without my change and it works ok, Sorry for wasting your time.

toonvandenbos commented 5 years ago

I'm glad you found a solution to your problem. Thanks for using NovaPage! ;)