whitecube / nova-page

Static pages content management for Laravel Nova
https://whitecube.github.io/nova-page
MIT License
238 stars 41 forks source link

Nova translations for tool lines #23

Open alex-osborn opened 5 years ago

alex-osborn commented 5 years ago

Great work with the package.

Currently the Nova tool label can be customised with config('novapage.label').

However, other strings in the tool are hard-coded and cannot be updated.

Screen Shot 2019-03-09 at 4 14 29 PM

Most of these could be run through translations to allow this, such as changing Whitecube\NovaPage\Pages\Resource::singularLabel()

    /**
     * Get the displayable singular label of the resource.
     *
     * @return string
     */
    public static function singularLabel()
    {
        return 'nova-page';
    }
    /**
     * Get the displayable singular label of the resource.
     *
     * @return string
     */
    public static function singularLabel()
    {
        return __('nova-page');
    }
toonvandenbos commented 5 years ago

Hi @alex-osborn,

Yep, you're right. We'll update those soon :)