whitecube / nova-page

Static pages content management for Laravel Nova
https://whitecube.github.io/nova-page
MIT License
238 stars 41 forks source link

When saving new option template, it required a "title" #49

Closed stufarquhar closed 4 years ago

stufarquhar commented 4 years ago

When saving a new option, it requires a "title". Nothing is saving to the DB table resulting in a Not null error.

v^0.2.3

toonvandenbos commented 4 years ago

Hi @stufarquhar,

Could you be more specific? Does the form show a validation error or do you get an exception when saving options?

I understand you're using the package with the database source. Does your static_pages table have nullable title (it should be if you used our latest migration)?

stufarquhar commented 4 years ago

Hi @Nyratas, yes I am using this as a database source. Latest version update had nothing to migrate?.. I manually changed the table to nullable and this seemed to work.

Regarding your first question, it threw an exception error a typical not null! All seems to be working well not. FYI, great package by the way!

toonvandenbos commented 4 years ago

Hi @stufarquhar,

I have to agree we didn't publish a new migration for this tiny change, but as you can see, the migration file now contains a nullable statement on the title attribute. Your manual change has the same effect as running the latest migration. I'm closing this issue now.

Thanks for the kind words and for bringing this to our attention!

stuartcusackie commented 1 year ago

I am also seeing this problem now 4 years later on Nova 4. I will open a new issue.