Made navigation links on the side bar localizable

whitecube / nova-page

Static pages content management for Laravel Nova

https://whitecube.github.io/nova-page

MIT License

239 stars 40 forks source link

Made navigation links on the side bar localizable #66

Closed CaddyDz closed 4 years ago

CaddyDz commented 4 years ago

Laravel reads config files before the Translator class is initialized, so config options must be localized on the view level

Signed-off-by: CaddyDz caddydz4@gmail.com

toonvandenbos commented 4 years ago

Hi @CaddyDz !

Thanks for your contribution. Could you also update the comment in the config file, indicating that translation keys can also be used instead of plain text labels? Thanks!

CaddyDz commented 4 years ago

@Nyratas done

voidgraphics commented 4 years ago

@Nyratas Seems OK to merge now, can you confirm?

toonvandenbos commented 4 years ago

Thanks @CaddyDz !

CaddyDz commented 4 years ago

No problem :) watching for releases