search

whiteoctober / IATI

AidView
aidview.net
7 stars 3 forks source link

CSV link in my Dashboard #41

Closed caprenter closed 11 years ago

caprenter commented 11 years ago

I have saved 2 activities in my dashboard in a group called 'David'

I can click on the group name from my dahboard overview page, I get to a summary page, Data File: David. But on that page the CSV link does not do anything for me.

I'm not sure if this link will work for everyone (can anyone see this link?) http://aidview-dev.herokuapp.com/data-file?ID=46004-42503&ID=44000-P120321&title=David

benfoxall commented 11 years ago

Yeah, I can see that link. And the csv link isn't enabled on that page (only works on the individual activity page)

caprenter commented 11 years ago

Thanks Ben.

So if the link is not enabled, should it not be there either? My preference would be to remove it - but that's just my preference.

siwhitehouse commented 11 years ago

No, we definitely should remove any links to functions that aren't available. This needs to be done for all of the pdf links too.

shenghuang commented 11 years ago

The CSV link gave the following error on my local deployment: 500 Error: API Response - Failed to parse XML at Request._callback (/home/ACDI-CIDA/sysuser/IATI-develop/lib/api.js:179:28) at Request.request.self.callback (/home/ACDI-CIDA/sysuser/node-v0.8.2/node_modules/request/main.js:99:22) at Request. (/home/ACDI-CIDA/sysuser/node-v0.8.2/node_modules/request/main.js:361:18) at Request.EventEmitter.emit (events.js:88:17) at IncomingMessage.Request.request.self.start.self.req.self.httpModule.request.buffer (/home/ACDI-CIDA/sysuser/node-v0.8.2/node_modules/request/main.js:327:16) at IncomingMessage.EventEmitter.emit (events.js:115:20) at IncomingMessage._emitEnd (http.js:366:10) at HTTPParser.parserOnMessageComplete as onMessageComplete at Socket.socketOnData as ondata at TCP.onread (net.js:404:27)

Any hints on how to address this issue? Thanks.

Sheng

siwhitehouse commented 11 years ago

We've also had an issue raised with http://aidview-dev.herokuapp.com/activities?Country=AO&view=list which shows a country view. It includes the csv option, but this doesn't work. If I go to the csv conversion tool http://tools.aidinfolabs.org/csv/direct_from_registry/ then it doesn't successfully parse the file.

So, another place where the csv link should be removed, please.

benfoxall commented 11 years ago

hi @shenghuang - can you provide the address that you saw that error with?

With fixing this issue, I'll remove the csv link for any page where it isn't implemented.

shenghuang commented 11 years ago

Sorry the site is an internal test site that cannot be accessed outside of our corporate firewall.

But I just downloaded the AidView-API-version_one.zip and IATI-develop.zip from Github so this issue should be able to be replicated by checking out the code then deploy on any server.

I also noticed the code is slightly different from the live http://www.aidview.net/ site, for example, one has "Area" the other has "Country".

Sheng

From: Ben Foxall notifications@github.com To: whiteoctober/IATI IATI@noreply.github.com Cc: shenghuang sheng_huang@acdi-cida.gc.ca Date: 11/27/2012 06:33 AM Subject: Re: [IATI] CSV link in my Dashboard (#41)

hi @shenghuang - can you provide the address that you saw that error with? With fixing this issue, I'll disable the csv link for any page where it isn't implemented. ? Reply to this email directly or view it on GitHub.

siwhitehouse commented 11 years ago

Checked for David's link and also the data file for CAFOD + LIBERIA. Both now showing without csv or pdf options.