search

whiteoctober / Pagerfanta

Pagination for PHP.
Other
1.59k stars 2 forks source link

Add method to identify which page the Nth item is on #242

Closed ale42 closed 6 years ago

ale42 commented 6 years ago

Add method to identify which page the Nth item is on.

Fixes #234.

Usage : 

$pagerfanta->getPageNumberForItem(35)

This should return 4 if there are 10 items per page and more than 35 items.

sampart commented 6 years ago

By the way, if you update your PR description to say "fixes #234", that issue will automatically close when this is merged :+1:

(Although now I've put that phrase in a comment, that might have the same effect anyway!)

ale42 commented 6 years ago

Hey @sampart , thanks for your review. I updated my code as you recommended :wink:

ale42 commented 6 years ago

PR updated @sampart :wink:

sampart commented 6 years ago

Congratulations on getting your first PR merged, @ale42. And thank you for improving Pagerfanta!